Conversation
…eat_index internal funcs
|
Meowdy! Here's your benchmark comparison: Benchmarks that have stayed the same:
|
kafitzgerald
approved these changes
Jan 14, 2026
Collaborator
kafitzgerald
left a comment
There was a problem hiding this comment.
This all looks good to me with perhaps the exception of listing it as a bug fix or something more user facing so that folks can easily find something to understand what happened should they notice a diff in the results.
cyschneck
approved these changes
Jan 15, 2026
Contributor
cyschneck
left a comment
There was a problem hiding this comment.
Looks good! I wonder if this will solve the issues I ran into when attempting to adding heat_index into applications (old PR that should be closed/fixed: NCAR/geocat-applications#124)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR rewrites
heat_indexto match the NWS's javascript implementation on https://www.wpc.ncep.noaa.gov/html/heatindex.shtmlSummary of changes:
_xheat_indexand_heat_indexand absorbed them into the mainheat_indexfunctionabsto the sqrt calculationIn case anybody needs to do this in the future, this is the script I ran on a chrome console on the webpage with the javascript:
Related Tickets & Documents
Closes #806 and #596
PR Checklist
General
docs/release-notes.rstin a relevant section for the upcoming release.Functionality
geocat/comp/__init__.pyfileTesting